fix: 미상 건수를 유료 요청에서 세고 모델 행을 가격으로 가른다 - #116
Merged
Merged
Conversation
The screen said "N requests with an unknown amount" and reached that N by subtracting the priced count from every request in the row. A self-hosted request has no amount at all rather than an unknown one, and a refusal never reached a provider, so the number counted both as something we had failed to learn. That is the error a card-level sentence was removed for, done again once per row. Rows that fold several models together now carry the paid-axis count and subtract from that. The model table does not: its two parts have to cover the model's requests without a remainder, so it splits on price and the screen draws the model as two whole rows, one with the amount and one without, each with its own tokens, latency and failure rate. Priced token and latency sums and a priced failure count travel with the row so neither row has to assume what the other holds. Rolled-up days keep zeros in the new columns until the watermark is reset, which the migration comment says how and when to do, along with what an automatic rollback to an older jar does to them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업내용
creditAxisRequests추가. 금액이 빠진 건수를 전체 요청이 아니라 유료 요청에서 빼게 함pricedRequests설명 정정. 「totalRequests와 견주면」이 자체 서빙 비중을 함께 담는 비율이라 견주지 말라고 다시 씀⭐️ 검증
mvn clean verify1321건 통과, 실패와 오류 0. 마이그레이션을 편집했으므로 clean으로 판정creditAxisRequests에 단언 추가. 그 조회를 덮는 시험 클래스가 하나뿐인 것을 먼저 세어 확인cost_usd가 있으면서 성공이 아닌 행이 0건,swept_before가 null💬 리뷰 포인트
priced_failed를 컬럼으로 둔 것. 「금액이 붙은 요청은 언제나 성공」은 라이브에서 0건으로 확인되지만 게이트웨이 동작이지 이 스키마의 보증이 아니라, 가정 대신 세기로 했다. 컬럼 하나를 아끼고 화면에 상수 0을 두는 갈래도 성립한다