fix: 검증 실패가 남긴 인증서 행을 지운다 - #115
Merged
Merged
Conversation
Verification puts the row in RENEWING when it starts and nothing moved it back when the domain parked FAILED, so the certificate screen reported "issuing" for a name whose issuance had never begun and never would. The two screens then disagreed about the same domain, which is how it was found. Only an unissued row goes: one that was ever ACTIVE, or that carries an expiry, is history worth keeping. Nothing is lost, because the reason the domain failed is on the domain row, and verifying again creates a fresh certificate row. The test was run against the unfixed code first and failed on the row that survives, so it catches the defect rather than merely passing beside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 작업내용
⭐️ 검증
💬 리뷰 포인트