Resolution adjustments - #68
Open
RobertCochran wants to merge 5 commits into
Open
Conversation
RobertCochran
commented
Aug 23, 2026
| }) | ||
|
|
||
| @Callback(direct = true, doc = """function():string or nil -- Return which of GPU or screen is limiting display capabilities, if either""") | ||
| def capabilityLimiter(context: Context, args: Arguments): Array[AnyRef] = |
Collaborator
Author
There was a problem hiding this comment.
I'm not married to this name, and honestly half-think it needs a better one. Suggestions welcome.
There was a problem hiding this comment.
cheesy, but, like, getTierConstraintSource()?
Comment on lines
+441
to
+444
| // FIXME: Assumes that GPU/screen tiers do not differ only by color depth, | ||
| // which is *currently* valid but may not be in the future. It would be | ||
| // better to just use the tier values directly, but I couldn't figure out | ||
| // how to access the physical screen from the TextBuffer... |
Collaborator
Author
There was a problem hiding this comment.
This implementation is slightly gross in that comparing GPU and screen tiers directly would make it work correctly in all cases without making assumptions about how graphics capabilities scale in the mod. If we can figure out how to make that happen, that'd be a much better implementation.
This reverts commit 9a6d95c. We're going to figure out how to solve the resolution downscaling issues in a different way that doesn't involve reducing the resolution on the computer side.
RobertCochran
force-pushed
the
resolution-adjustments
branch
from
August 23, 2026 06:45
7a04067 to
b4f738d
Compare
Collaborator
Author
|
<rebased and force-pushed to resolve merge conflicts> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Multi-item PR to make using higher tier screens nicer in OpenOS:
Limit OpenOS to 80x25 at boot time. T3 screens can be mildly uncomfortable to use at full resolution on a 1080p screen at moderate GUI scale, and T4 is even worse. It is still possible - just as before - to use theUndid this, as there was disagreement about this being the correct solution for the downscaling issues it was trying to fix. We're gonna try solving this a different way later.resolutionprogram to set the resolution manually at any time.gpu.capabilityLimiter()- to quickly determine if there is a GPU/screen tier mismatch. Returns"gpu"if screen tier > GPU tier,"screen"if GPU tier > screen tier, ornilif they are matched in capability. This is theoretically something you could have already done, but it required grovelling throughcomputer.getDeviceInfo()and knowing the precise values of the 'product name' for each GPU and APU and their max resolution widths, and would break if any of these predicating assumptions ever changed (unlikely, but still annoying).resolutionprogram to take a--maxparameter to tell you the maximum supported system resolution, and using the new driver feature, whether or not you have a bottleneck in your hardware setup. It just plain wasn't able to do this before; it could only set a chosen resolution or return the current resolution. More necessary now that OpenOS no longer boots to the display's max resolution and thus max resolution needs to be more discoverable, but was otherwise an (IMO) sorely needed QoL enhancement.