Fix controller autoplay via EventBus subscription - #7
Open
NNowakowski wants to merge 1 commit into
Open
Conversation
The Harmony patch on DialogController.HandleOnCueShow only fires for keyboard/mouse input. Subscribing to the game's EventBus via IDialogCueHandler fires for all input modes including controller. Add DialogCueListener which implements IDialogCueHandler and is subscribed in Main.Load(). Remove HandleOnCueShow_Postfix from UiDialogController_Patch to avoid double-firing autoplay on keyboard/mouse. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Harmony patch on DialogController.HandleOnCueShow only fires for keyboard/mouse input. Subscribing to the game's EventBus via IDialogCueHandler fires for all input modes including controller.
Add DialogCueListener which implements IDialogCueHandler and is subscribed in Main.Load(). Remove HandleOnCueShow_Postfix from UiDialogController_Patch to avoid double-firing autoplay on keyboard/mouse.
A fix that I've added as part of my personal efforts to replace the windows TTS of this mod with an ElevenLabs integration. Thought I'd backport it to your version as I've seen a few people asking for controller support and this atleast reenables the autoplaying of dialog.