Skip to content

Set new Campaign Remote manager on Curve Pool Boosters - #2964

Open
sparrowDom wants to merge 4 commits into
masterfrom
sparrowDom/VotemarketManagerUpdate
Open

Set new Campaign Remote manager on Curve Pool Boosters#2964
sparrowDom wants to merge 4 commits into
masterfrom
sparrowDom/VotemarketManagerUpdate

Conversation

@sparrowDom

@sparrowDom sparrowDom commented Aug 5, 2026

Copy link
Copy Markdown
Member

Overview

This PR replaces the old CampaingRemoteManager with the new one. The StakeDAO team have migrated to a new implementation in this transaction

Also fixes the --no-isolate error since --no-isolate doesn't exist in forge 1.5.1 forge script only has opt-in --isolate, and isolation is off by default, so the flag was expressing the default.

Governance proposal

Repoint Curve Pool Boosters to the new Stake DAO CampaignRemoteManager

Code Change Checklist

To be completed before internal review begins:

  • The contract code is complete
  • Executable deployment file
  • Fork tests that test after the deployment file runs
  • Unit tests *if needed
  • The owner has done a full checklist review of the code + tests

Internal review:

  • Two approvals by internal reviewers

Deploy checklist

Two reviewers complete the following checklist:

- [ ] All deployed contracts are listed in the deploy PR's description
- [ ] Deployed contract's verified code (and all dependencies) match the code in master
- [ ] Contract constructors have correct arguments
- [ ] The transactions that interacted with the newly deployed contract match the deploy script.
- [ ] Governance proposal matches the deploy script
- [ ] Smoke tests pass after fork test execution of the governance proposal

@naddison36 naddison36 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've verified the 12 pool boosters and the gov proposal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants