Repository navigation
Conversation
The contract deliberately stays untracked: scope and hygiene keep proofline.json out of the tree, so a pushed commit does not carry it. gateAtCommit materialized a worktree of the commit and refused with "no proofline.json" because the fresh worktree never holds an untracked file. Copy the root's contract into the worktree when the commit does not track one, so the gate runs against the same bytes the root gates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A contract that keeps proofline.json untracked (scope allow-lists exclude it, hygiene requires it untracked) can never pass hookPrePush: gateAtCommit builds a worktree of the pushed commit, and a fresh worktree never contains an untracked file, so every gate refuses with "no proofline.json (run: proofline init)".
The fix copies the root's proofline.json into the fresh worktree when the commit does not track one, so the gate verifies the commit against the same contract bytes the root gates. Tracked contracts are untouched; nothing else changes.
Measured red-green on a real repo holding such a contract: before the patch the push refuses for every commit; after it the per-commit gate runs and passes.