Repository navigation
Conversation
The approved proposal bytes replace proofline.json: two tasks (PL-CRIT01: crit:<id> claims and leading (?i)/(?s)/(?m) grep flags; PL-NEXT2: version 0.2.0-next.2) and one sentence in the notes. No other task changes. File sha256 59f854a31a2d2e4c46d7ce5d4c2dc03b12e19f272fb07ba80eb0bf46cc3ec819. proofline.json.sig is my owner signature over the canonical hash 9d33ec9beee1bd22eb6bcf9975afdd7e2dbde742ec040b1877d117c3210ed334. Signed-off-by: mgillr <[email protected]>
…grep pattern may start with (?i) or (?s) An intake or measurement task adds no test file. Its proof is a command the gate runs, so the tests column had nothing the repository lookup could find, and "-", "n/a" and "none" count as naming no test. I made the tests column take crit:<criterion id>. It holds only when the id is a criterion of the claimed task, it ran in this gate, it is a command, metric, test_red_green or docs check, and it passed. An unknown id, another task's criterion, a grep, file_exists, scope or wiring check, or a criterion that did not pass is a claim mismatch with that reason. Any other name is still looked up in the repository. The gate hands checkClaim the id, type and status of each criterion it ran. The grep verifier built new RegExp(pattern, flags), and JavaScript refuses a leading (?i) or (?s), the way the Python verifier in x402-conformance's CI writes flags, as an invalid group. Those criteria crashed here and the gate was BLOCKED for a contract that passes there. A leading (?i), (?s) or (?m) now becomes flags added to the criterion's own. A pattern without one is unchanged and stays case-sensitive. test/claims_crit.test.mjs and test/grep_inline_flags.test.mjs fail on the parent and pass here. Signed-off-by: mgillr <[email protected]>
I moved the version to 0.2.0-next.2 in package.json and package-lock.json and put the Unreleased changelog entries under a dated 0.2.0-next.2 heading, so the version on npm carries PL-CRIT01. 0.2.0-next.1, the current latest and next, predates it. Signed-off-by: mgillr <[email protected]>
The approvals entry names the exact approved bytes (file sha256 59f854a31a2d2e4c46d7ce5d4c2dc03b12e19f272fb07ba80eb0bf46cc3ec819), so the self-gate sees the owner approval in CI and not only on the signing machine. Signed-off-by: mgillr <[email protected]>
The self-gate reads .proofline/config.json to find the approvals directory; an absolute machine path does not exist in CI, so the tracked config points at the repo-relative directory that holds the marker. Signed-off-by: mgillr <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I land contract v4.5h (owner-signed, canonical sha256 9d33ec9beee1bd22eb6bcf9975afdd7e2dbde742ec040b1877d117c3210ed334), PL-CRIT01 (crit: claims, leading (?i)/(?s)/(?m) grep flags) and PL-NEXT2 (version 0.2.0-next.2).