Repository navigation
I refuse any unapproved contract change as one blocked line - #43
Merged
Merged
Conversation
The setup fixtures now commit their contract before the base. No assertion changes and no test is removed. weakenings() stays the explanation on that one line, including a real weakening. A change that clears ci.tasks is refused before the empty-list path. Verified against base acaf53c: the new test is red on the base and green now, the suite exits 0 (157 of 157), and the 25 changed files are in scope. The main-branch criterion stays open until this lands. Signed-off-by: mgillr <[email protected]>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup fixtures commit their contract before the base. No assertion changes and no test is removed. A contract change is one blocked line, and weakenings() stays the explanation, including a real weakening. A change that clears ci.tasks is refused before the empty-list path.
Verified against base acaf53c: the new test is red on that base and green now, the suite is 157 of 157, and the 25 changed files are in scope. The main-branch criterion stays open until this lands.