Repository navigation
Fix DeleteHostGroupAssignmentClonesJob deleting all hostgroups - #139
Open
light-foot wants to merge 1 commit into
Open
light-foot wants to merge 1 commit into
light-foot wants to merge 1 commit into
Conversation
When a ZabbixHostgroupAssignment assigned to a ConfigurationGroup was deleted, the cleanup job deleted ALL hostgroup assignment clones for every member of that config group instead of only the clones of the one hostgroup that was removed. Matches the bug pattern already correctly handled by DeleteTagAssignmentClonesJob and DeleteTemplateAssignmentClonesJob. Two missing pieces: - signal: .delay() omitted zabbixhostgroup_pk, so the job never knew which specific hostgroup was deleted - job: _delete() filter omitted zabbixhostgroup_id=self.zabbixhostgroup_pk, so it matched and wiped all (object, configgroup) hostgroup rows Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a ZabbixHostgroupAssignment assigned to a ConfigurationGroup was deleted, the cleanup job deleted ALL hostgroup assignment clones for every member of that config group instead of only the clones of the one hostgroup that was removed. Matches the bug pattern already correctly handled by DeleteTagAssignmentClonesJob and DeleteTemplateAssignmentClonesJob.
Two missing pieces: