Filed issue #970: label preflight pagination aborts run. - #971
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Filed issue #970: label preflight pagination aborts run.#971opencode-agent[bot] wants to merge 1 commit into
opencode-agent[bot] wants to merge 1 commit into
Conversation
Contributor
|
User opencode-agent[bot] does not have write permissions |
Contributor
kcov coverageLine coverage ran for this PR and uploaded a non-blocking report artifact named |
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
Filed #970 with label
visual-test.Diagnosis: The failure is at
.github/workflows/visual-test.yml:55-66(Ensure visual-test label exists), not in Vulkan/screenshot code.gh label listreturns only 30 labels (default pagination) but the repo has 41, sorun-visual-test(index 31) is invisible to the precheck; the subsequentgh label createthen fails withlabel with name "run-visual-test" already exists, the step exits 1 underset -euo pipefail, and the rest of the job (Lavapipe setup, screenshot capture, golden diff) is skipped.Evidence:
build-output.logmissing from workspace (game never ran)weston.logshows weston started and was killed by SIGTERM from theStop headless Wayland compositorstep (if: always())gh label list --repo OpenStaticFish/ZigCraftreturns 30,--limit 100returns 41weston.log:62caught signal 15is the stop action, not a weston crash8d205ff, so the regression is recurringThe Zig paths (
vulkan_swapchain.zig:127,app.zig:268-276,screenshot.zig:24-44) were never entered. Also noted that the diagnose prompt is stale (.ppmvs the workflow's.png; oldsrc/game/screens/home.zigvs the currentmodules/game-ui/src/screens/home.zig).Triggered by scheduled workflow
opencode session | github run