Filed #966: label preflight pagination bug. - #967
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Conversation
Contributor
|
User opencode-agent[bot] does not have write permissions |
Contributor
kcov coverageLine coverage ran for this PR and uploaded a non-blocking report artifact named |
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![Fix with [code]smith](https://pr-comments-assets.blacksmith.sh/codesmith/fix-with-codesmith-light.png)
Filed issue #966 with the
visual-testlabel.Root cause: The failure is in
.github/workflows/visual-test.yml:55-68(Ensure visual-test label exists), not in any Vulkan/swapchain/screenshot code.gh label list --json namepaginates at 30 entries; the repo has 41 labels, sorun-visual-test(position 41) falls off page 1, the script tries to recreate it,gh label createexits 1 with "label already exists", and every later step (Lavapipe setup, screenshot capture, log upload) is skipped. Onlyweston.logsurvived. Confirmed independently:gh label list --json namereturns 30 entries (norun-visual-test),--limit 100returns 41 (includes it).The PPM hypothesis from the prompt is also stale —
visual-test.yml:81already passes-Dscreenshot-path=screenshot.png, andscreenshot.zig:262-268accepts.png. The Zig/Vulkan code paths are never exercised.Issue: #966
Triggered by scheduled workflow
opencode session | github run