Filed #954: label preflight pagination bug. - #955
Open
opencode-agent[bot] wants to merge 1 commit into
Open
Conversation
Contributor
|
User opencode-agent[bot] does not have write permissions |
Contributor
kcov coverageLine coverage ran for this PR and uploaded a non-blocking report artifact named |
Contributor
|
Found 1 test failure on Blacksmith runners: Failure
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filed issue #954 at #954 with label
visual-test.Summary of what I found:
build-output.logwas missing from the workspace (onlyweston.logsurvived, showing the compositor was SIGTERMed at 3.5s with no game output ever produced)..github/prompts/visual-test-diagnose.md:7-9,42-43is stale: it claims the workflow uses-Dscreenshot-path=screenshot.ppm, but.github/workflows/visual-test.yml:81actually uses-Dscreenshot-path=screenshot.png, andbuild.zig:1065documents the option as a PNG capture. The PPM hypothesis would not match this run regardless.build-output.log, noscreenshot.png, weston killed early) is the same shape as the recurring failure tracked in [Visual Test] Label preflight prevents screenshot capture on run #26 #942, [Visual Test] Label bootstrap failure prevents menu screenshot run #944, [Visual Test] Label preflight aborts before screenshot capture #945, [Visual Test] Label preflight skips Lavapipe screenshot capture #946, [Visual Test] Workflow fails before game runs: 'Ensure visual-test label exists' step rejected by duplicate label #947, [Visual Test] Label preflight rejects duplicate label, skipping Lavapipe screenshot capture #950, and [Visual Test] Label preflight rejects duplicate label on run #30192579914, skipping Lavapipe screenshot capture #952: theEnsure visual-test label existsstep at.github/workflows/visual-test.yml:55-68callsgh label listwithout--limit, which returns only the first 30 of the repo's 41 labels. Therun-visual-testlabel falls off page 1, theif !body runsgh label create, which fails withlabel with name "run-visual-test" already exists; use --force to update its color and description, the step exits 1, and every later step (includingRun menu screenshot capture) is skipped.gh label list --json name --jq '.[].name' --limit 100and append|| trueto thegh label createcalls. Also update the diagnose prompt to drop the stale.ppmreferences.Triggered by scheduled workflow
opencode session | github run