Skip to content

hit_ceiling set for downward movement instead of upward - #735

Open
github-actions[bot] wants to merge 1 commit into
devfrom
opencode/schedule-eb5879-20260531192659
Open

hit_ceiling set for downward movement instead of upward#735
github-actions[bot] wants to merge 1 commit into
devfrom
opencode/schedule-eb5879-20260531192659

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Issue #734 has been created successfully on GitHub at #734 with:

  • Title: [Audit][Medium] hit_ceiling boolean set on downward Y movement when passing through collision
  • Label: automated-audit

Summary of the finding: In modules/engine-physics/src/collision.zig:89-93, the hit_ceiling flag is incorrectly set when the player moves downward (move.y < 0). The logic is backwards - hit_ceiling should only fire when moving upward into an overhead block, not when falling and hitting the ground. This is a logic bug where grounded and hit_ceiling can be set incorrectly.

Triggered by scheduled workflow

New%20session%20-%202026-05-31T19%3A26%3A58.142Z
opencode session  |  github run

@github-actions

Copy link
Copy Markdown
Contributor Author

This pull request has had no activity for 60 days. It will be closed in 14 days unless there is new activity or an exemption label is added.

@github-actions github-actions Bot added the stale label Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants