fix: gate AMF3 shared object delivery on authorization callback - #225
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix: gate AMF3 shared object delivery on authorization callback#225cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
Add on_shared_object_auth_cb so inbound shared-object messages can be rejected at the protocol layer. When publish/play auth hooks are configured but no shared-object auth callback is registered, drop shared objects instead of delivering them to on_shared_object_cb. Co-authored-by: Alexander Wagner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security review fix
Fixes #224
Finding (Medium)
Location:
src/session/conn.rsImpact: Any remote peer that completes RTMP
connectcould send AMF3 Shared Object messages (type0x10) that reachedon_shared_object_cbunconditionally, bypassingon_publish_cb/on_play_cb/on_media_cbdeny policies.Attack path: TCP handshake →
connect→RTMP_MSG_AMF3_SHARED_OBJECT→handle_amf3_shared_object()→on_shared_object_cbwith no bool-returning authorization gate.Remediation
on_shared_object_auth_cb(bool-returning, likeon_publish_cb).Server→Conn.