[com4]: Add thalweg computation option#1320
Open
PaulaSp3 wants to merge 8 commits into
Open
Conversation
Contributor
Analysis for project
|
| Tool | Category | Rule | Count | |
|---|---|---|---|---|
| ripgrep | Lint | # TODO: we could put this checking part in an extra function, if we can move updateInfraDirGraph | 10 | ❌ |
| ruff | Style | Incorrect formatting, autoformat by running qlty fmt. |
1 | ❌ |
| qlty | Structure | Deeply nested control flow (level = 4) | 19 | |
| qlty | Structure | Function with high complexity (count = 26): tileInputLayers | 6 | |
| qlty | Duplication | Found 17 lines of similar code in 2 locations (mass = 140) | 2 | |
| qlty | Structure | High total complexity (count = 71) | 1 |
@qltysh one-click actions:
- Auto-fix formatting (
qlty fmt && git push)
Contributor
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (6)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
PaulaSp3
force-pushed
the
PS_thalweg_onlyFP
branch
from
July 23, 2026 10:26
b82c060 to
8c33e6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The goal is to derive thalweg data for each flow path (release from one release cell or from all cells having the same release ID).
The location of a thalweg is derived as the center of zDelta or energy or flux of the locations within one generation.
So the computation within the flowCore.py is changed so that we remember and track which cells are hidden within each generation.
Please be aware that simulations with computing thalwegs increases the computation time and the consumed RAM.
Short description of the changed files:
com4FlowPy/com4FlowPy.py
com4FlowPy/flowClass.py
com4FlowPy/flowCore.py
com4FlowPy/flowPath.py
com4FlowPy/splitAndMerge.py
data/avaParabChannelPaperFP:
in3Utils/geoTrans.py:
runCom4FlowPy.py:
runScripts/runRegionalThalweg2DPlot.py:
runStandardTestsCom4FlowPy.py:
PR Checklist
Please confirm before requesting review:
pytestlocally without failsConfirm before the final merge/rebase into master