Conversation
Jeronymous
approved these changes
Aug 26, 2026
Jeronymous
left a comment
Jeronymous
left a comment
Member
There was a problem hiding this comment.
It looks good.
It could be factorized, but the original code was not, so I have no issue with continuing to do copy-pasting. Two small comments below
| ), | ||
| suite=("lighteval",), | ||
| hf_repo="lightonai/mgsm-rev2", | ||
| hf_revision="1463c6dc7991a8751b8e28e76f6c561b9201eb55", |
Member
There was a problem hiding this comment.
Why to enfore the revision here?
It's the last one. You want to be defensive in case the dataset is updated in the future?
| # reuses the same QA prompt and metric. There is no train split, so it is run zero-shot. | ||
| mgsm_rev2_tasks = [ | ||
| LightevalTaskConfig( | ||
| name=f"mgsm_rev2_{language.value}", |
Member
There was a problem hiding this comment.
suggestion: mgsm-rev2_{language.value} ? (dot instead of underscore)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add MGSM-rev2 task (lightonai/mgsm-rev2)
Adds the revised MGSM benchmark for 11 languages (en, es, fr, de, ru, zh, ja, th, sw, bn, te). Test split only and no chain-of-thought field, so the tasks run zero-shot.
Dataset
Paper
Changes