fix(electron): keep collapsed header clear of macOS window buttons - #231
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS Electron, collapsing the sidebar leaves a 48px rail while the native hiddenInset window buttons remain at the top left. The main header previously began at x=64, allowing its title or session icon into that area. This follow-up to #190 reserves an 80px safe zone: add 32px of header padding beside the collapsed rail, or 80px when the mobile layout has no rail.
The header follows the existing sidebar preference. Expanded-sidebar spacing and Web/Windows layouts retain their existing padding. This PR changes only MainContentHeader; the other changes from #190 are already on main.
Validation:
Related: #190.