Conversation
Every method CodeQL's java/missing-override-annotation reported (1327 locations across 226 files) gets @OverRide immediately above its signature, at the exact line the alert points to. Purely additive: no other code changes. Verified by building the whole reactor from the root pom - javac fails hard on an @OverRide that doesn't actually override anything, so a clean build across all 28 modules is the real proof the placements are correct, not just that they compile by accident.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the remaining ~1327
java/missing-override-annotationCodeQL alerts — the last largenote-severity category from the ongoing CodeQL cleanup series (#122, #123, #126, #128, #130–#134).Change
Every location CodeQL's
java/missing-override-annotationflagged gets an@Overrideline inserted immediately above the method signature, at the same indentation, at the exact line the alert points to. 226 files, purely additive — 1327@Overrideinsertions plus the CDDL "Portions Copyright" header line on files that did not already carry one (220 via the standard header pattern, 6 with non-standard or missing headers handled individually).No other code changes: no renames, no logic touched, no reordering.
Verification
@Overrideis compiler-checked —javacfails hard when it is placed on a method that does not actually override or implement anything from a supertype ("method does not override a method from its superclass"). Rather than review 1327 insertions by hand, the real proof is a clean build: the entire reactor was built from the rootpom.xml(mvn install, all 28 modules) after the insertions, with no manual fixes needed afterward.Result: BUILD SUCCESS, all 28 modules, 1442 tests, 0 failures, 0 errors (164 skipped, same skips as on
master) — includingconnector-framework-internal(469 tests) andldap-connectorwith its embedded OpenDJ (159 tests). Also spot-checked ~30 random insertions by hand across different files and annotation styles (interface method declarations, anonymous inner classes, nested static classes) before the build, all correctly placed.Note for merge order
This branch is cut from
origin/masterlike the other open CodeQL PRs in the series and was not rebased against any of them. Several files here are also touched by #126, #128, #131, #132, and #133 (e.g.AesGcmEncryptor,WebSocketConnectionGroup,CSVFileConnector), so merging this one will need a rebase of whichever of those merge after it — nothing here should conflict semantically (this PR only ever adds an@Overrideline, never touches the same line another PR modifies), but the merge order across the series is a judgment call, not mine to make unilaterally.