Fix GitHub Copilot identified issues in rc-5.0.1 cross-merge

[andrew-platt]

Ready to merge

Feature or improvement description

Fix three code quality issues identified by GitHub Copilot in PR #3432:

1. AeroAcoustics.f90: Prevent out-of-bounds array access

   • Add guard for single-node case (NumBlNds==1)
   • Calculate LastElemPct safely without accessing NumBlNds-1 index
   • When NumBlNds==1, treat element as spanning entire blade (100%)

2. IfW_FlowField.f90: Improve error messaging for cubic interpolation

   • Clarify why acceleration field is required for cubic velocity interpolation
   • Provide context-specific error messages for three scenarios:
     • Both acceleration output and cubic interpolation enabled
     • Only acceleration output requested * Only cubic velocity interpolation enabled

3. FVW_IO.f90: Add I/O error handling in ResolveGridAxis

   • Add iostat check to grid point list file read loop
   • Return controlled error with line number and filename on read failure
   • Prevent unhandled runtime crashes from malformed/truncated files

Additional supporting information
These issues were found during review of a cross-merge from rc-5.0.1 to dev with PR #3482

Generative AI usage
Co-authored-by: GitHub Copilot [email protected]
Co-authored-by: Claude Sonnet 4.5 [email protected]

Test results, if applicable
No results affected

[Copilot]

Pull request overview

This PR addresses three code-quality issues found during an rc-5.0.1 → dev cross-merge, focusing on safer edge-case handling and clearer runtime diagnostics.

Changes:

• Prevents an out-of-bounds access in AeroAcoustics blade-span percentage checks when NumBlNds == 1.
• Improves InflowWind fatal error messaging when cubic velocity interpolation and/or acceleration output requires a valid acceleration field.
• Adds iostat checking while reading OLAF grid point list files to fail gracefully on malformed/truncated input.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
modules/inflowwind/src/IfW_FlowField.f90	Expands validation/error paths for cases where cubic time interpolation requires a valid acceleration field.
modules/aerodyn/src/FVW_IO.f90	Adds iostat handling to prevent uncontrolled crashes when reading grid point list files.
modules/aerodyn/src/AeroAcoustics.f90	Guards last-element percentage calculation for single-node blades to avoid invalid indexing.

Suppressed comments (1)

modules/inflowwind/src/IfW_FlowField.f90:92

• The cubic-interpolation fatal message repeats “accel field” after stating “acceleration field”, which is inconsistent and slightly harder to read. Using consistent wording would improve clarity.

      else  ! FF%VelInterpCubic
         call SetErrStat(ErrID_Fatal, "Cubic velocity interpolation requires a valid acceleration field, but accel field is not valid", &
                         ErrStat, ErrMsg, RoutineName)

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.