2.2.8 - #262
Open
TobiasRoeddiger wants to merge 66 commits into
Open
Conversation
✅ Unit tests passed2 passed, 0 failed/error, 0 skipped — view workflow run
Download the |
Define UUID 0x1410df99 for DMIC gain control characteristic. This allows BLE clients to adjust the ADAU1860 digital microphone gain over Bluetooth.
Add public methods mic_gain_write() and mic_gain_read() to safely access DMIC_VOL0 and DMIC_VOL1 registers. These methods encapsulate the private register access functions and allow external code to control microphone gain for channels 0 and 1.
Implement hw_codec_mic_gain_set(), hw_codec_mic_gain_get_left(), and hw_codec_mic_gain_get_right() functions. These provide a hardware abstraction layer for controlling ADAU186x DMIC_VOL registers with 0.375 dB step resolution across a +24 dB to mute range.
Add read_dmic_gain() and write_dmic_gain() handlers for the BT_UUID_DMIC_GAIN characteristic. This allows BLE clients to read and adjust DMIC gain for left and right channels using a 2-byte payload [left_reg, right_reg].
Add comprehensive documentation for DMIC microphone gain control including: - Hardware register mapping and gain calculations - BLE protocol specification - Usage examples - C/C++ API reference - Implementation details Replaces deprecated PDM terminology with DMIC to accurately reflect the ADAU1860 digital microphone interface.
|
Build output available: |
…Service - Removed the seal_check_service.c and seal_check_service.h files. - Added audio_response_service.h to define the audio response service interface. - Updated main.cpp to initialize the audio response service instead of the seal check service.
The connection callback returns void, so stop processing with a plain return after a parameter-update failure instead of attempting to return the error value.
Initialize the application LED state and BMP388 FIFO sample data before they are passed to downstream code. This prevents uninitialized fields from being observed on valid error and partial-frame paths.
Only adjust and consume the FIFO length after reading it successfully. This avoids updating FIFO state or issuing a read with an undefined length after an I/O failure.
Return before selecting the Earable button when the callback does not contain its pin. This prevents dereferencing an uninitialized button pointer for an unexpected interrupt mask.
Reuse the released TX buffer when no alternative buffer is available so tx_buf cannot remain null before memset().
Validate the stereo channel count before consuming both channel pointers. If encoding fails, drop the frame instead of entering the fatal error path, log once until recovery, and never send stale encoded data.
Initialize the conditionally compiled scan parameter to NULL and describe the chip-ID copy in terms of its actual alignment and aliasing constraints.
Continue through volume and mute restoration when a codec step fails, return the first error, and only persist the requested mode after all hardware operations succeed.
Track the rare I2S underrun fallback where no alternate TX buffer is available and the released TX buffer is reused as silence. Log the first occurrence and then rate-limit later warnings so this recovery path does not fail silently during testing.
|
Build output available: |
|
Build output available: |
CodeChecker static analysis✅ No non-style issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.