Repository navigation
fix(benchmarks): distinguish TCP frame boundary diagnostics - #59
Merged
Merged
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A malformed length prefix could previously appear as
input_frame_ready: truein the native TCP control's timeout diagnostics because the matcher uses the same completion flag for valid frames and invalid-prefix errors.Report readiness only for an allowed complete frame. Add a bounded
frame_boundaryobject identifying empty/incomplete/invalid prefixes, incomplete frames and complete frames, with declared, buffered, required and missing byte counts. At most nine prefix bytes are exposed; payload is omitted. The matcher, protocol, workload, deadlines and send/receive state machines are unchanged.Permanent native
--self-testcases cover the invalid-prefix sentinel, partial/full/trailing frames, the unchanged 4096-byte cap, truncated nine-byte prefixes and UINT64_MAX. English/Chinese production-readiness documentation describes the schema and its limits.Local acceptance at
c5a3581052d317779684bec308b04d293d772b63: Boost Release and AddressSanitizer + UndefinedBehaviorSanitizer targeted checks passed (leak detection disabled), clang-format 18, 99 CI policy tests passed with one explicit PowerShell-unavailable skip, Nimbus 40 tests and 257 pages /674 references passed, and four actual bilingual HTML articles/Markdown exports were inspected. Standalone Asio 1.38.2 Release/TLS-off registered self-tests also passed after restoring the official pinned headers. Full hosted cross-platform acceptance remains pending. No connection load, capture or capacity measurement was run.This improves diagnosis; the cause of the 5,000-connection stall remains unresolved.