Repository navigation
build(deps): update fast-uri and harden Net shutdown tests - #157
Merged
nick2781 merged 10 commits intoOct 26, 2026
Merged
Conversation
Replace Consul creation macros with typed bases, a private owning factory and explicit DLL entry points. Preserve interface registration, disabled updates and request behavior, and add construction/lifecycle checks with bilingual migration guidance. BREAKING CHANGE: Consul implementation and plugin class layouts change. Rebuild Consul and its consumers together; all existing public types and logical header paths remain available.
Bumps [fast-uri](https://github.com/fastify/fast-uri) from 3.1.8 to 3.1.9. - [Release notes](https://github.com/fastify/fast-uri/releases) - [Commits](fastify/fast-uri@v3.1.8...v3.1.9) --- updated-dependencies: - dependency-name: fast-uri dependency-version: 3.1.9 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
dependabot
Bot
added
dependencies
nick2781
changed the title
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 26, 2026
Check a successful live-listener negative control, retain the exercised TCP peer across manager shutdown, and require a remote EOF or reset before stopping that peer. Check listener closure using an exact refused new connection instead of global immediate port rebinding. Keep existing endpoint ownership, manager state, main-thread callbacks and pending HTTP cancellation assertions. The original macOS CI bind conflict holder was not reproduced locally; no production shutdown or reuse-address behavior changes.
Use a private io_context, async_connect and the existing five-second deadline. Cancel and close the probe socket on expiry, return typed timed_out rather than operation_aborted, and drain connect and timer callbacks before returning. Keep all live-listener, retained-peer and owner-state assertions and the existing test timeout. Production shutdown remains unchanged.
nick2781
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the documentation build's transitive fast-uri dependency from 3.1.8 to 3.1.9. Also correct the native Net DSO shutdown regression, whose final same-port rebind aborted on macOS with
Address already in useafter shutdown. The particular address holder was not reproduced or identified; this change does not attribute the failure to TIME_WAIT or SO_REUSEADDR.The regression now keeps its actual message-sending client alive across manager shutdown and requires remote EOF/reset, expired endpoint ownership, stopped/repeated-stop state and exactly
connection_refusedon a new listener probe. The same probe must first connect to the real live listener. Its asynchronous five-second deadline drains cancellation callbacks and reportstimed_outdistinctly. Existing HTTP future/cancellation and manager-thread callback assertions remain; production code, socket options and existing test/supervisor deadlines are unchanged.Local validation: actual Net/Bus/Utility DSO regression passed; a live-listener fault control correctly failed the closed-listener assertion; a bound-only socket control verified bounded typed timeout handling. clang-format 18, 155 CI contracts and Nimbus checks (137 pages /275 references) passed at
7364fa1431977dd64aeda310e27c386d1bb25b64, whose complete source tree matches the independently validated native-fix revision. Original CI results remain preserved. A fresh source run and complete protected cross-platform candidate are required before merging.