Skip to content

[GRADLE-WRAPPER] Worker isolation log visiblity update & documentation fix#24310

Open
xsveda wants to merge 2 commits into
OpenAPITools:masterfrom
xsveda:worker-isolation-fix
Open

[GRADLE-WRAPPER] Worker isolation log visiblity update & documentation fix#24310
xsveda wants to merge 2 commits into
OpenAPITools:masterfrom
xsveda:worker-isolation-fix

Conversation

@xsveda

@xsveda xsveda commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

wrokerIsolation property status message always appears in the build output. This pollutes the log significantly in builds when a multiple standalone specs are to be processed. Our current projects generates over 130 individual open api specs. Similar to #11211 where more such scenarios are described.

CC: @Picazsoo

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Suppress worker isolation status logs when Gradle runs with --quiet to reduce build noise in projects with many specs. Update the Gradle plugin README to correctly document classloader as the default workerIsolation.

Written for commit 39d2e2b. Summary will update on new commits.

Review in cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Re-trigger cubic

@Picazsoo

Copy link
Copy Markdown
Contributor

Hello @xsveda, thanks for raising this issue and providing the PR.

I understand the reasoning for moving the message to info, but I worry it becomes too hard to discover. The workerIsolation parameter is a fairly new/obscure option. When set incorrectly it either increases memory pressure or slows down generation (by starting separate JVM per task), so the user should be able to pick their preferred trade-off. I presume this message is the main way users learn the parameter exists and how to switch modes. At info it only shows with --info (verbose and global), so most people would never see it.

Since #23831 added a quiet flag, could we gate the message behind that instead of lowering the log level? It stays visible by default (keeping the hint discoverable) while still giving a clean way to silence it, and it stays consistent with the banner suppression. Something like:

if (quiet.getOrElse(false) != true) {
    logger.lifecycle("[openApiGenerate] Worker isolation: ...")
}

on both branches. The quiet property is already wired in, so it should be a small change. What do you think?

For context: when I updated the Gradle plugin to support the modern worker features, I added this isolation choice precisely because the wrong mode had bitten me before, so I'd really like to keep it visible rather than tucked away behind --info.

@xsveda xsveda force-pushed the worker-isolation-fix branch from 51bf7cf to fc84cfd Compare July 15, 2026 11:52
@xsveda

xsveda commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Thank you @Picazsoo for the hint, I did not realise the quiet mode flag is already available in this context.

I agree, this is much better approach 👍

@Picazsoo

Copy link
Copy Markdown
Contributor

But to think of it, the obnoxious workerIsolation message could also announce the possibility of using the quiet flag 🤔.

@Picazsoo

Copy link
Copy Markdown
Contributor
image

Hi @xsveda this failure isn't related to your changes. The openapi-generator-gradle-plugin-mvn-wrapper job failed on a transient network error while downloading the Gradle distribution:

Could not install Gradle distribution from 'https://services.gradle.org/distributions/gradle-8.14.4-bin.zip'

Just revert and reapply your last commit, then push to retrigger the tests:

That should get CI to run again and it will hopefully pass.

This is how I do it.

@xsveda xsveda force-pushed the worker-isolation-fix branch from fc84cfd to 39d2e2b Compare July 15, 2026 13:12
@xsveda xsveda changed the title [GRADLE-WRAPPER] Worker isolation log level update & documentation fix [GRADLE-WRAPPER] Worker isolation log visiblity update & documentation fix Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants