Repository navigation
Conversation
Review widened P1: day_session_windows now ends an early close at 13:00 for aggregation, the open-stamped filter and the session-close fill. The plans and direction docs still assigned all of D19 to the engine rewrite. Mark it shipped except the close-stamped time_in_session, log the two review commits in the P1 plan, and strike the copy items 87ba511 already fixed. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review commits on #638 (
1acb75dc,87ba5117) fixed most of D19, but the plans and direction docs still assign it to the engine rewrite.87ba5117fixed.time_in_session, reached only by close-stamped frames (vnpy_simulation, test doubles).Docs only. Dated checks: #639.
🤖 Generated with Claude Code