You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
admin: decide what the overview's failure count means #647
After #641, the overview's top_failure_categories[].affected_users means three different things depending on the range and the filters (query_service.py:951-978):
Past days, no dimension filter: the sum of each day's distinct-user affected_users rollup. A user who fails on 5 days counts 5 times, so this is user-days.
Today: distinct users in today's raw slice, added on top.
Billing/provider/model filter set:event_count rows, so it counts events. The PR body notes this case.
On main it is distinct users over the whole range, from one raw read (query_service.py:750-760). The page shows it in a column labelled "Count".
Options:
Keep the computation and rename the field (and label) to what it counts.
Return distinct users over the range. The per-day rollups can't give that: it needs a raw-event read (bounded by the 180-day retention) or a new rollup.
Count events everywhere: sum event_count and drop the affected_users path.
The activation funnel has the same shape (query_service.py:933): it sums the per-day distinct activation_users rollup across days. Whatever is decided here should apply there too.
Decided on cost: the fix must not add reads or storage.
Failure categories: count events, filtered or not. The data comes from the rollups' event_count rows plus today's slice, which that view already reads. The field is renamed event_count and the page column reads "Events". rollup_day stops writing the affected_users rows, which nothing reads any more. Done in feat: move admin analytics reads to daily facts #641 (b32c843); design D13 amended.
Activation funnel: keeps summing per-day distinct users, so a user who repeats a step on two days counts twice. Exact distinct counts would need a raw-event read on every overview load. Events don't make sense for a funnel.
Activity
fix: count admin failure categories as events on every path
FlyM1ss commentedon Oct 17, 2026
Decided on cost: the fix must not add reads or storage.
event_countrows plus today's slice, which that view already reads. The field is renamedevent_countand the page column reads "Events".rollup_daystops writing theaffected_usersrows, which nothing reads any more. Done in feat: move admin analytics reads to daily facts #641 (b32c843); design D13 amended.This closes when #641 merges.