Repository navigation
chore: smith 1.10.1, and the e2e suites declare the playwright they import - #317
Merged
Merged
Conversation
…mport - office-reader, captcha-tesseract and studio-desktop import playwright in their e2e suites but only reached it by npm hoisting core's dependency; each declares it now, so the playwright convention finds them without the flavour markers - install.sh writes the Windows PATH itself since smith 1.10.1 (monosmith #290): the workflows' cygpath workaround goes - the hand-added e2e-browsers dependencies stay: 1.10.1 still drops a plugin's dependency under a depends_on override (reported on monosmith #283) Refs #313 Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01TjR6eM2tUwU3NGnKXsmEap
Release previewNothing to release. Unchanged: agent, office-reader, core, probe, studio, cli, mcp, azure-durable, captcha-tesseract, ocr-tesseract, opencraw |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #316, moving to smith 1.10.1.
office-reader,captcha-tesseractandstudio-desktopimportplaywrightin their e2e suites but only got it because npm hoists@opencraw/core's dependency. Each declares it as a devDependency now. The playwright convention then finds all five suites by itself, so the"flavour": "library"markers go.studioandstudio-desktopkeep"display": true.install.shwrites the Windows path toGITHUB_PATHitself since smith 1.10.1 (install.sh: on a Windows runner, GITHUB_PATH gets the Git Bash path, so cmd/PowerShell steps can't find smith monosmith-app/monosmith#290), so thecygpathlines in the five workflows go. All workflows andci.ymlpin smith 1.10.1."e2e-browsers"entries insmith.toml. smith 1.10.1 is meant to keep a plugin's dependency under adepends_onoverride, but on OpenCraw it doesn't: without them,smith run e2e -p office-reader --no-cacheruns no browser install. That passes locally only because Chromium is already installed. Reported on playwright: root-hoisted playwright is not detected, and a depends_on override drops e2e-browsers monosmith-app/monosmith#283.Verified locally:
smith run lint typecheck test build: 61/61 tasks succeeded.npm run lint:workspace: passes.smith ci generate --check: up to date.npm ci --dry-run(npm 12): passes.office-reader's e2e: 3 passed, withe2e-browsersrunning first.🤖 Generated with Claude Code
https://claude.ai/code/session_01TjR6eM2tUwU3NGnKXsmEap