Repository navigation
fix(ci): read npm 12's pack --json object when staging apps - #254
Merged
Merged
Conversation
…d VS Code apps npm 12 answers pack --json with an object keyed by package name instead of an array, so packed[0] was undefined and the pack step failed on main, blocking every release since 12 October. Co-Authored-By: Claude Sonnet 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_014yC6LN4a8qnR7gu3QmRnbg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on main has failed in the pack phase since 12 Oct, so nothing is released (including #253). `npm pack --json` under npm 12 returns an object keyed by package name, not an array; `packed[0].filename` threw `Cannot read properties of undefined (reading 'filename')` in `stage-app.mjs` and `package-vsix.mjs`.
Fix
Take the first value with `Object.values(packed)`, which works for both shapes.
🤖 Generated with Claude Code