chore: [SDK-5280] raise SDK deployment target to iOS 15 - #1749
Conversation
- Set IPHONEOS_DEPLOYMENT_TARGET to 15.0 on every target in OneSignal.xcodeproj and OneSignalExample.xcodeproj. Xcode 27 rejects anything lower, so the project did not build on it - Declare iOS 15 in both podspecs and Package.swift. CocoaPods stamps the podspec platform onto the pod target, which is what broke CocoaPods consumers on Xcode 27 - Update the README, the migration guide and the bug report template's iOS version list
8eaf929 to
2816e0e
Compare
|
so we should update the wrappers too @nan-li , also is there no legacy code to remove 12-14? |
abdulraqeeb33
left a comment
There was a problem hiding this comment.
Do we have to update the documentation as well?
Note: Minimum iOS is different from DEPLOYMENT_TARGET
Good point, I added a ticket to look at removing code and including wrappers too if there is code there.
@abdulraqeeb33 Good call, we should be clearer with language. Unles you meant to call out something else, or just we should use consistent terminology? |
Just the language - I think when we update the docs, please keep that in mind. |
Description
One Line Summary
Raise the SDK's deployment target from 12 to 15. SDK-5280.
Details
Motivation
Xcode 27 refuses to build anything with a deployment target below iOS 15. That broke this project for local development and broke CocoaPods customers on Xcode 27, because CocoaPods copies the podspec's platform version onto the pod target. Swift Package Manager customers were not affected.
Scope
Testing
Unit testing
No test changes.
Manual testing
Built the test app on Xcode 27.0 with no command-line override and ran the OSCore tests and the subscription race tests on an iPhone 17 Pro simulator. 187 tests, all passing.
Affected code checklist
Checklist
Overview
Testing
Final pass
🤖 Generated with Claude Code