Repository navigation
docs: [SDK-5253] describe Identity Verification in MIGRATION_GUIDE.md - #1581
Draft
sherwinski wants to merge 1 commit into
Draft
sherwinski wants to merge 1 commit into
sherwinski wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
1 Line Summary
Replace the "Identity verification is not functional" lines in
MIGRATION_GUIDE.mdand add a section that describes Identity Verification in the Web SDK.Details
userJwtInvalidatedevent to the User namespace table.login(externalId, jwtToken),updateUserJwt(externalId, token), and the event. It also states this behavior under Token Identity Verification:logout()disables the push subscription of the user that logs out, and a laterloginwith a JWT restores it.loginwith a JWT.Init order: SDK-5242 is still in Backlog. Until it is done, the guide tells developers to call these methods inside
OneSignalDeferred.push.Legacy player ID: SDK-5247 removed the legacy player ID lookup for all apps. Thus the guide does not say that the lookup is skipped only under Identity Verification.
Version: 160900 is the expected version of the next minor release (SDK-5257). Keep this PR as a draft until that release. Change the version if the release uses a different number.
The
oxfmtformatter realigned the whole User namespace table because the new rows are wider. The rows that existed before have no text changes.The docs half of this ticket is in the mintlify-docs repo (linked in the ticket).
The ticket asks to tell the mobile owners that the Android and iOS migration guides still have the old text. This PR does not do that.
Systems Affected
Validation
Tests
Info
Documentation only. No source code changed.
vp fmt --check MIGRATION_GUIDE.md: passes.vp check --fix) passed.main:OneSignal.updateUserJwt,LoginManager._beginLogoutUnderIv,OperationRepo._shouldSuppressAnonymousOp, andonUserJwtInvalidatedinsrc/shared/listeners.ts.Checklist
Programming Checklist
Interfaces:
Functions:
Typescript:
Other:
elem of arraysyntax. PreferforEachor usemapcontextif possible. Instead, we can pass it to function/constructor so that we don't callOneSignal.contextScreenshots
Info
Not needed. Markdown change only.
Checklist
Related Tickets
SDK-5253