Skip to content

arsenik-qmk not cleaning up config and rules #88

Description

@rlepretre

The current implementation only deletes the keymap and appends the config and rules to the existing files which can cause issues and confusion when tweaking the arsenik_config.h file. Since commenting out a #define line if you already ran the script once will not remove the option from the config since the line will appear twice, once uncommented and once commented out in the target config.h file.

    rm "$arsenik_folder"/keymap.*
    cat ./arsenik_config.h >> "$arsenik_folder/config.h"
    cat ./rules.mk >> "$arsenik_folder/rules.mk"
    cp ./keymap.c ./arsenik.h ./keymap_ergol.h "$arsenik_folder"

Is this intended behavior ?

If this is not, I would suggest the following improvement :

    rm "$arsenik_folder"/*
    cp ./arsenik_config.h "$arsenik_folder/config.h"
    cp ./rules.mk "$arsenik_folder/rules.mk"
    cp ./keymap.c ./arsenik.h ./keymap_ergol.h "$arsenik_folder"

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions