Skip to content

Fetch Items Callback Crashes When Fetch List Emptied Under High Lag #10

Description

@itsnun

I wanted to let you know about a crash I keep encountering on servers when using the fetch and refill feature in "BetterBaritoneBuild". It never happens in single player, but under packet delays the client throws a “NoSuchElementException” and disconnects.. After the module finishes shift clicking items out of a linked chest, it schedules a “fetch items” event. On a laggy server, that event can fire after the fetch list has already been emptied by earlier inventory updates. The callback unconditionally tries to grab the first material from the list, even though the list is now empty. That out of bounds access is what triggers the exception.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions