Repository navigation
Fix progress bars, RCSB/FPSubSim2 robustness, and add dataset/API features - #15
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings
masterup to date with a large batch of work ondev: correctness fixes across download/conversion, RCSB matching, and FPSubSim2 similarity search; crash-safety and retry hardening for network/file operations; several new convenience APIs; and broad progress-bar/notebook UX fixes. It also adds substantial new test coverage.New features
PapyrusDataset.downloadfor per-dataset descriptor downloadscreate_fp_subsim_searchto the object-oriented (oop) API, documented in the advanced querying notebookcollectalias foraggregateleave_leveloption to control QSAR/PCM progress bar behaviorFixes
papyrus++key breaking the conversion progress totalread_protein_descriptorsfor a bare ProDECDescriptorexitafter an unknown fingerprint parameter in the fpsubsim2 CLIFPSubSim2.create()fingerprint to Morgan instead of building all ~10 fingerprint types (was a ~5.6x slowdown trap)Binarydecoding in FPSubSim2 mappingsort_db_filemodelling.pyRobustness & performance
desc_type='all'descriptor joins via ids and streaming; bound chunk memory and widen the chunk cell budget for wide descriptor-table conversiondesc_typebefore downloading descriptorskeep_original_files=Falsecupy[ctk]extra for GPU supportDocs & notebooks
create_fp_subsim_searchin the advanced querying notebookTests
.get()/construction for every type, download chunk-stream retry/cleanup,keep_original_files/keep_xzforwarding, legacy papyrus++ key fallback, modelling progress-bar closure, neural network feature standardization, and more🤖 Generated with Claude Code