Repository navigation
chore: Clear the Fallow baselines the cleanup paid off - #256
Merged
Merged
Conversation
Changes: - Empty the duplication baseline - Re-save the health baseline from the current code, which has no finding over the limits The cleanup stack fixed every finding the baselines held, so stale entries would only hide a regression in the same files.
✅ Deploy Preview for disscount ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 34 minutes. View limit details
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Fallow cleanup stack (#235 to #255) fixed every complexity and duplication finding the baselines held. Leaving those entries would let the same files regress without the audit noticing.
Changes
frontend/.fallow-baselines/dupes.json: emptyfrontend/.fallow-baselines/health.json: re-saved from the current code; no function is over the limits, only Fallow's advisory refactoring targets remainTesting
fallow audit --base origin/devreportspassfallow healthandfallow dupesreport no findings over the limits