Repository navigation
[PL-81] - Fix achievement progress updates never reaching the Twitch announcer and silently skipping an achievement's first progress tick - #70
Merged
kzryzstof merged 1 commit intoSep 19, 2026
Conversation
on_xbox_achievements_progressed() only signaled achievements-changed on the unlock branch, so the Twitch announcer's diff handler never ran for in-progress updates. Separately, the diff itself required a prior recorded progress value, silently skipping an achievement's very first progress tick.
kzryzstof
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The progress-announcement feature added for PL-81 never actually posted to Twitch chat: Xbox's in-progress achievement updates never reached the announcer's diff logic, and even once they did, an achievement's very first progress tick had no prior recorded value to compare against and was silently skipped.
Changes
monitoring_service.c: firenotify_achievements_changed()from the "still in progress" branch ofon_xbox_achievements_progressed(), not just the unlock branch, so the Twitch announcer's diff handler actually runs on progress ticksachievement_announcer.c: treat a missing priormeasured_progressvalue the same as a changed one, so an achievement's first progress update after baseline is announced instead of silently droppedRelated
Generated by describe-pr skill v1.1.0