Repository navigation
[PL-89] - Harden the universal FreeType download against flaky mirrors with fail-fast curl, SourceForge fallback, and checksum plus archive validation - #65
Merged
Conversation
The build-universal-freetype.sh script fetched the release tarball with `curl -L` (no --fail), so an HTTP 502 from Savannah's mirror was saved as the .tar.xz and handed to tar, failing the macOS CI build with "Unrecognized archive format". Make the download robust: fail on HTTP errors, retry, fall back from Savannah to SourceForge, and validate the archive (SHA-256 + tar test) before extraction so a corrupt or error-page response is never trusted. Co-Authored-By: Claude Opus 4.8 <[email protected]>
kzryzstof
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The macOS Universal CI build fetched the FreeType release tarball from Savannah with a plain
curl -L. When Savannah's mirror redirect returned an HTTP 502, the error page was saved asfreetype-2.13.2.tar.xzand passed totar, failing the build withUnrecognized archive format. This makes the FreeType download resilient to flaky/broken mirrors so a transient mirror outage no longer breaks the build.Changes
curl --fail --location --retry 3 --retry-all-errorsplus connect/max timeouts, so HTTP 4xx/5xx fail fast (no error page written) and transient failures are retried without hanging on a dead mirror.verify_archivehelper that validates the download by known-good SHA-256 (FreeType 2.13.2) and atar -tfstructural test before extraction.Related
Generated by describe-pr skill v1.1.0