Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both metadata cacher examples currently fail when copied and executed: the automatic-stage example calls
geet_path()during saving, and both examples savethe_best_numberbut readbest_numberduring loading.Use the existing
get_path()method and the same metadata key in save/load. Add tests that extract and execute the actual documentation code blocks rather than maintaining separate copies. One test runs the real stage decorator through saving and a cache hit; the other checks explicit inline metadata saving/loading.Before the documentation correction, the two tests fail with
AttributeErrorandKeyError. After it, both pass. Black, isort, flake8, andgit diff --checkpassed. The repository-wide suite and full documentation site were not run for this change.This contribution was developed with AI assistance and verified against the real cache implementations.