Repository navigation
Save iteration counts and add allReduce for convergence status - #148
Open
nkoukpaizan wants to merge 14 commits into
Open
nkoukpaizan wants to merge 14 commits into
nkoukpaizan wants to merge 14 commits into
Conversation
nkoukpaizan
marked this pull request as ready for review
October 20, 2026 15:24
Collaborator
|
Checking number of iterations to converged solution was used as a (poor) replacement for derivatives (Jacobian and Hessian) unit tests. It has been poorly designed and highly unreliable. I suggest we remove these checks altogether because they add little value and significant maintenance overhead. Instead, I would focus on completing Hessian unit tests, which are the last remaining test that need to be implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request type
Relates to
This MR updates
Summary
This saves the number of iterations from the solvers (uniformly named as
number_iterationsper comments on #46).This is a partial, isolated, fix from the nicholson/testing-cmake-scopflow-fix branch, used in recent Frontier runs. #66 already contributed the changes needed to run larger number of contingencies. DCOPF workaround is the remaining component. cc @tsybinae
I left one change (HIOP iterations counts) commented out to minimize the diffs. Uncommenting if will require updating the test values. We may remove the checks for number of iterations altogether.
Linked Issue(s)
Closes #42 by adding an all reduce of the convergence status.