Skip to content

Save iteration counts and add allReduce for convergence status - #148

Open
nkoukpaizan wants to merge 14 commits into
developfrom
nicholson/save-iteration-counts
Open

nkoukpaizan wants to merge 14 commits into
developfrom
nicholson/save-iteration-counts

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Oct 19, 2026 •

Copy link
Copy Markdown
Collaborator

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

This saves the number of iterations from the solvers (uniformly named as number_iterations per comments on #46).

This is a partial, isolated, fix from the nicholson/testing-cmake-scopflow-fix branch, used in recent Frontier runs. #66 already contributed the changes needed to run larger number of contingencies. DCOPF workaround is the remaining component. cc @tsybinae

I left one change (HIOP iterations counts) commented out to minimize the diffs. Uncommenting if will require updating the test values. We may remove the checks for number of iterations altogether.

Linked Issue(s)

Closes #42 by adding an all reduce of the convergence status.

@nkoukpaizan nkoukpaizan self-assigned this Oct 19, 2026
@nkoukpaizan nkoukpaizan added bug Something isn't working enhancement New feature or request labels Oct 19, 2026
@nkoukpaizan
nkoukpaizan marked this pull request as ready for review October 20, 2026 15:24
@nkoukpaizan
nkoukpaizan requested a review from pelesh October 20, 2026 15:24
@pelesh

pelesh commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Checking number of iterations to converged solution was used as a (poor) replacement for derivatives (Jacobian and Hessian) unit tests. It has been poorly designed and highly unreliable. I suggest we remove these checks altogether because they add little value and significant maintenance overhead.

Instead, I would focus on completing Hessian unit tests, which are the last remaining test that need to be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SCOPFLOW with EMPAR solver always reports CONVERGED, does not enforce N-1 security

2 participants