Skip to content

Constraint Jacobian test completion - #136

Merged
pelesh merged 21 commits into
olcf-hackathon-2026-devfrom
nicholson/cecj-test
Oct 15, 2026
Merged

pelesh merged 21 commits into
olcf-hackathon-2026-devfrom
nicholson/cecj-test

Conversation

@nkoukpaizan

@nkoukpaizan nkoukpaizan commented Oct 3, 2026 •

Copy link
Copy Markdown
Collaborator

Merge request type

  • New feature
  • Resolves bug
  • Documentation
  • Other

Relates to

  • OPFLOW
  • SOPFLOW
  • SCOPFLOW
  • TCOPFLOW
  • CMake build system
  • Spack configuration
  • Manual
  • Web docs
  • Other

This MR updates

  • Header files
  • Source code
  • CMake build system
  • Spack configuration
  • Web docs
  • Manual
  • Other

Summary

This completes the analytical constraint Jacobian unit tests. Started from #38 (thanks @PhilipFackler) and
used Claude to help identify the differences in the network generation scripts and the bug in the reference solution assembly.

  • Equality (jac_eq_acopf) and inequality (jac_ineq_acopf) tests: reference base Jacobians in cecj.csv / cicj.csv, tiled to the number of copies.
  • Fix: inequality reference Jacobian row scaling for multiple copies (generator and line rows).
  • New variant: inequality test without line limits (zero line ratings, -no_line_limits, cicj_nolinelimits.csv).

These are CPU-only tests. GPU tests with these analytical solutions are future work, as they require some cleanup of the interface. HIOPSPARSEGPU is covered by covered by test_eqjac_gpu, test_hess_gpu and test_ineqjac_gpu using some tricks to call the GPU methods directly.

@nkoukpaizan nkoukpaizan self-assigned this Oct 3, 2026
@nkoukpaizan
nkoukpaizan marked this pull request as ready for review October 7, 2026 14:05
@nkoukpaizan
nkoukpaizan requested a review from pelesh October 7, 2026 14:05
@pelesh pelesh added this to the Release 2.2 milestone Oct 7, 2026
@nkoukpaizan nkoukpaizan changed the title Equality constraint Jacobian test completion Constraint Jacobian test completion Oct 15, 2026
@pelesh
pelesh merged commit 92d7046 into olcf-hackathon-2026-dev Oct 15, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants