Repository navigation
Constraint Jacobian test completion - #136
Merged
Merged
Conversation
20 tasks
nkoukpaizan
marked this pull request as ready for review
October 7, 2026 14:05
pelesh
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge request type
Relates to
This MR updates
Summary
This completes the analytical constraint Jacobian unit tests. Started from #38 (thanks @PhilipFackler) and
used Claude to help identify the differences in the network generation scripts and the bug in the reference solution assembly.
jac_eq_acopf) and inequality (jac_ineq_acopf) tests: reference base Jacobians incecj.csv/cicj.csv, tiled to the number of copies.-no_line_limits,cicj_nolinelimits.csv).These are CPU-only tests. GPU tests with these analytical solutions are future work, as they require some cleanup of the interface.
HIOPSPARSEGPUis covered by covered by test_eqjac_gpu, test_hess_gpu and test_ineqjac_gpu using some tricks to call the GPU methods directly.