[FIX] base_fontawesome_web_editor: fix icon to image conversion#3684
Open
janni1288 wants to merge 1 commit into
Open
[FIX] base_fontawesome_web_editor: fix icon to image conversion#3684janni1288 wants to merge 1 commit into
janni1288 wants to merge 1 commit into
Conversation
FontAwesome >= 6.7.2 declares icon glyphs via the --fa custom property instead of the classic content CSS declaration. Odoo core's fontToImg() still expects content: to extract the glyph, causing a crash. Synthesize a content declaration from --fa when present.
OCA-git-bot
added
series:17.0
mod:base_fontawesome_web_editor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3457
Problem
Sending a chatter message (or any HtmlField) containing a FontAwesome
icon crashes with
TypeError: Cannot read properties of null (reading '1')when the icon's CSS rule uses FontAwesome >= 6.7.2's
--facustomproperty instead of a classic
contentdeclaration.Fix
_processRuleSelectorsnow synthesizes acontent: "..."declarationfrom
--fawhen no classiccontentdeclaration is present, so Odoocore's
fontToImg()can extract the glyph as it did before FA 6.7.2.Known limitation
Icons introduced only in FontAwesome 6 (not present in Odoo's bundled
server-side font used for
/web_editor/font_to_img) still can't berendered as a converted image. This is a separate, pre-existing
limitation unrelated to this crash fix.