Conversation
…ng on main (review follow-up)
petlenz
force-pushed
the
fix-141-ci-hardening
branch
from
September 20, 2026 19:46
926fdb6 to
067b1fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #141. Closes #13 — this delivers its last remaining item. Closes #27 — CPM sources now cached (actions/cache v6.1.0 SHA-pinned, key = hash of the two pin-carrying CMakeLists), plus per-job timeout-minutes (45 build, 60 sanitize) (the ASan/UBSan job — the other two #13 items, the numsim-cas pin and test -Werror, landed previously).
Workflow (
build.yml):permissions: contents: read(default token had write on push builds)actions/checkoutSHA-pinned to v4.2.2 (11bd7190...) — was the one movable ref in an otherwise SHA-pinned supply chainconcurrencygroup cancelling superseded PR runs (never main/scheduled)sanitizejob: gcc-14 Debug,-fsanitize=address,undefined -fno-sanitize-recover=all, full ctest including the Phase-B e2e gate (FETCH_MATERIALS=ON)Fetch pins (
tests/CMakeLists.txt): googletest and Eigen moved from movable tags (v1.14.0,3.4.0) to the corresponding commit SHAs;GIT_SHALLOWdropped where a raw-SHA fetch makes it unreliable (CPM auto-disables it for hash tags).Pre-verified locally so the new job starts green: full suite 321/321 under ASan+UBSan, plus the Phase-B
numsim_material_check_driver(17/17, CPM-pinned siblings) under the same flags — zero sanitizer reports. Fresh configure with the SHA pins resolves cleanly.