Conversation
petlenz
force-pushed
the
fix-15-moose-stateful-output
branch
from
September 20, 2026 19:46
857b3b7 to
9075efd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15.
The MOOSE Phase A boundary guard checked only inputs for stateful roles. An
add_output(..., roles::History)(or anyis_statefulrole) passed through silently and emitted a plain, non-statefulMaterialPropertywrite — a material that compiles but is semantically wrong (no old/new pair, no stateful init), leaving the user to deduce the bug from incorrect simulation results.MooseMaterialTarget::emit()now applies the same guard symmetrically over outputs, throwing a clear error pointing at the Phase B roadmap.src/targets/moose_material.cpp— mirror the stateful-input guard for outputs.tests/MooseTargetTest.cpp—RejectsStatefulOutputnegative test.The comprehensive negative-path suite (#11) also covers this guard once it lands.