Ask for an XMLRPC size limit rtorrent accepts - #3260
Merged
Conversation
php/settings.php asks for 67108863. rtorrent 0.16.22 refuses it -- "XMLRPC size limit cannot exceed the SCGI content size limit" -- so since Novik#3257 sent the request on its own it fails quietly and the limit stays at the default of 524288. Torrent files travel through XMLRPC in load.raw_start, so on 0.16.22 only small ones can be added. The value was never reachable on any version. SCgiTask::max_content_size is (2 << 23) in 0.16.21 and 0.16.22 alike and scgi_task.cc refuses any request whose CONTENT_LENGTH exceeds it: on 0.16.21 a request declaring 16777217 is closed unanswered while 16777216 is served. 0.16.22 only began refusing to configure a size its transport was never going to carry. 16777216 is that ceiling. Both versions accept it, it raises the limit where 67108863 left it at the default, and it is already the maximum php/xmlrpc_proxy.php lets a caller ask for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
php/settings.php asks for 67108863. rtorrent 0.16.22 refuses it -- "XMLRPC size limit cannot exceed the SCGI content size limit" -- so since #3257 sent the request on its own it fails quietly and the limit stays at the default of 524288. Torrent files travel through XMLRPC in load.raw_start, so on 0.16.22 only small ones can be added.
The value was never reachable on any version. SCgiTask::max_content_size is (2 << 23) in 0.16.21 and 0.16.22 alike and scgi_task.cc refuses any request whose CONTENT_LENGTH exceeds it: on 0.16.21 a request declaring 16777217 is closed unanswered while 16777216 is served. 0.16.22 only began refusing to configure a size its transport was never going to carry.
16777216 is that ceiling. Both versions accept it, it raises the limit where 67108863 left it at the default, and it is already the maximum php/xmlrpc_proxy.php lets a caller ask for.