Fix inverted sort icons in Oblivion, OblivionBlue, MaterialDesign and DarkBetter themes - #3255
Merged
Merged
Conversation
…emes Novik#2836 inlined each theme's asc.gif (asc.svg for DarkBetter) as --header-asc-icon. Before that change stable.js drew asc.gif on a descending sort, so in these three themes the file is a down arrow and ascending columns now show it, with the rotated copy on descending. Use each theme's pre-Novik#2836 desc image instead. It is the up arrow these themes always showed for an ascending sort. The default theme and the Acid, Blue and Excel themes received new up-pointing icons in Novik#2836 and are unaffected.
OblivionBlue reuses the Oblivion icon, which points down. Use the theme's own desc.gif, the up arrow, for --header-asc-icon.
Randrage
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3254
#2836 inlined each theme's
asc.gif(asc.svgfor DarkBetter) as--header-asc-icon. Before that changestable.jsdrewasc.gifon a descending sort, so in the Oblivion, MaterialDesign and DarkBetter themes that file is the down arrow, and ascending columns now show it. OblivionBlue, added later in #2914, reuses the Oblivion icon and has the same problem. The default theme and the Acid, Blue and Excel themes received new up-pointing icons in #2836 and are not affected.This patch sets
--header-asc-iconin the four themes to theirdescimage (pre-#2836 for the first three, the theme's ownimages/desc.giffor OblivionBlue), the up arrow these themes always showed for an ascending sort. One line per theme, no other changes.Verified by decoding the four new data URIs (all point up, matching the base icon in
css/stable.css) and on a v5.2.10 install with all four themes after a cache clear.