Add a check for implicitly nullable parameters - #3252
Merged
Conversation
A parameter written `int $count = null` is nullable by implication. PHP 8.4 deprecates that spelling, so every call into such a function emits a deprecation notice from shipped code, into whatever log PHP writes to, which an operator cannot fix without editing the tree. The signatures were made explicit in Novik#3217. This scans the shipped tree for the spelling so it cannot come back, reading the files rather than reflecting on them: plugins are loaded a request at a time, and a file no test happens to include would otherwise go unchecked.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A parameter written
int $count = nullis nullable by implication. PHP 8.4 deprecates that spelling, so every call into such a function emits a deprecation notice from shipped code, into whatever log PHP writes to, which an operator cannot fix without editing the tree.The signatures were made explicit in #3217. This scans the shipped tree for the spelling so it cannot come back, reading the files rather than reflecting on them: plugins are loaded a request at a time, and a file no test happens to include would otherwise go unchecked.