fix(onion_checker): handle Ahmia verification token, drop dead DarkSearch, annotate module_status (#535)

[Fire162]

Closes #535

Summary

modules/onion_checker.py previously failed to return results due to two issues:

1. Ahmia verification token: Ahmia requires a dynamic rotating hidden input token from the home page. Requests to /search/?q=... without this token received a 302 redirect back to /, causing empty search results.
2. DarkSearch: darksearch.io is permanently unreachable and always resulted in network failures.
3. Both failures were silently swallowed, returning an empty OK result rather than reporting failures.

Changes

1. Ahmia Token Handling:
   • In _search_ahmia (modules/onion_checker.py), first perform a GET https://ahmia.fi/ using a single requests.Session to extract the rotating hidden input token name and value.
   • Include the extracted token pair as query parameters in the subsequent search request (https://ahmia.fi/search/?q=...&<token_name>=<token_val>).
2. Remove DarkSearch:
   • Removed _search_darksearch and cleaned references to DarkSearch in the source code, UI cards (frontend/src/components/views/ScanResults.tsx), TypeScript definitions (frontend/src/lib/types.ts), and documentation (README.md, docs/ARCHITECTURE.md).
3. Module Status Annotation:
   • Annotated module results using annotate(..., OK) on success and annotate(..., ERROR, reason) when target is empty or Ahmia lookup fails (missing token, non-200 HTTP response, or request exception).
4. Tests:
   • Updated tests/test_v2_1_modules.py with tests verifying:
     • Extraction of rotating hidden token and successful Ahmia search.
     • Accurate aggregation and filtering of Ahmia results.
     • Reporting status: error upon network failure.
   • All tests pass.

[github-actions]

Thanks for the first pull request here. CI needs a maintainer to approve the run before it starts, so it may sit for a bit before anything happens. pytest tests/ -q passing is the main thing I look at.

[NovaCode37]

Checked it live: a search for "bitcoin" returns 25 results again, and the tests pass. Thanks.