Update liblouis to 3.38.0 - #11
Open
henrikottesorensen wants to merge 1 commit into
Open
Conversation
Five releases on from 3.33.0, which was March 2025. Notable for this wrapper are memory safety fixes in code paths it P/Invokes directly: a heap buffer overflow in back_passDoAction, a segfault in lou_compileString, and missing length validation in _lou_backTranslate. The version and its checksum are the only functional change; everything else derives from them. The two remaining 3.33 references were examples in comments and documentation. Verified rather than assumed: - All eight RIDs build. win-arm64 still needs the -Wl,--add-stdcall-alias workaround, so that upstream assumption survives, as expected. - The glibc floor is unchanged: 2.34, 2.33, 2.33 for linux-x86, x64 and arm64. That decides which distributions can consume the packages, and new upstream code is exactly what could raise it. - Every binary exports all eighteen P/Invoke entry points and depends on nothing outside its platform allowlist. 3.38 exports 34 lou_ functions where 3.33 exported 30. - The tests pass, so the tables still compile. 3.38 rejects uppercase virtual dots, which is its one backwards incompatible change, and none of Nota's tables use them. 475 tables now stage, up from 444. Co-Authored-By: Claude Opus 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Five releases on from 3.33.0, which was March 2025. Independent of the other open PRs — it touches
Directory.Build.propsand one line ofPACKAGING.md, and nothing else.Why now
3.38.0 fixes several memory safety issues in code paths this wrapper P/Invokes directly:
back_passDoActionlou_compileString_lou_backTranslate_lou_compileTranslationRuleand_lou_compileDisplayRuleThe change is two lines
The version and its checksum. Everything else derives from them — the per-RID package versions,
LibLouis.NET.Tables, and theruntime.liblouisdependency range. The other two3.33references were examples in a comment and in the docs, updated so they don't drift.The checksum was taken from the release tarball and then re-verified from an independent download.
Verified, not assumed
linux-x862.34,linux-x642.33,linux-arm642.33 — identical to 3.33The glibc floor is the one that could have gone wrong quietly.
linux-x86sits exactly on 2.34, so any new upstream code reaching for a newer symbol would have pushed it over and dropped RHEL 9, Debian 12 and Ubuntu 22.04 consumers. It didn't.win-arm64still needs the-Wl,--add-stdcall-aliasworkaround:configure.accontinues to assume*mingw*implies x86 in 3.38, so that stays.3.38 exports 34
lou_functions where 3.33 exported 30. 475 tables stage, up from 444.Behaviour worth knowing
3.38's one backwards-incompatible change is that the table compiler now rejects uppercase virtual dots (
A–F); only lowercase is valid. None of Nota's tables use them — the tests compile those tables, and they pass.3.38 also fixes "a long-standing typo with
begnum mtin all 5 Danish Grade 2 tables". That touches upstream'sda-dk-g26.ctbandda-dk-g28.ctb, but Nota's forks of those shadow them in the test output, so the tests are unaffected. It is a real difference for anyone consumingLibLouis.NET.Tablesdirectly, and a further sign that Nota's tables have drifted behind upstream — see #10.🤖 Generated with Claude Code