Repository navigation
Conversation
zomop
marked this pull request as draft
November 11, 2026 09:43
zomop
marked this pull request as ready for review
November 11, 2026 09:59
zomop
marked this pull request as draft
November 11, 2026 14:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a few issues with friends and conversation pagination.
Some requests could stop before all pages were fetched, repeated cursors could cause pagination to get stuck, and incomplete responses could overwrite valid cached data. I also found that numeric and string user IDs were not always matched correctly when checking trusted friends.
I fixed the pagination handling, added cursor validation, improved response validation, and made sure incomplete requests preserve the existing cache. I also fixed trusted-friend ID matching.
Tests:
I think that's pretty much it.