State the rename-recovery test timeout - #6
Merged
Merged
Conversation
The rename-recovery test runs three full clone-and-reclone scenarios in one body, where its neighbours in the file run one each. On the windows-latest runner that total sits on Bun's 5000ms default: the 2.2.1 pull request passed on all three platforms, and the identical commit then timed out at 5061ms on the push to main. The budget is now stated at 20s, matching the explicit timeout already carried by the cross-platform release validation test, so the scenario count rather than the runner's spawn latency decides the outcome. Co-Authored-By: Claude Opus 5 <[email protected]>
The owner, name, and casing renames shared one body and one budget, so a failure named the trio rather than the case that broke and the three clone pairs were billed against a single timeout. Each case is now its own test.each row. The current folder and slug are identical across all three, so they are hoisted and only the previous pair varies. The stated budget drops from 20s for the trio to 10s per case, against the 2s each costs on the windows-latest runner. Assertion count is unchanged at 111 for the file. Co-Authored-By: Claude Opus 5 <[email protected]>
NomadicDaddy
pushed a commit
that referenced
this pull request
Sep 10, 2026
- Removed .nvmrc containing '24' — implied Node.js/nvm usage but project uses Bun - Node version already documented in package.json engines field - Updated spec.md Known Limitations: removed resolved item #6, renumbered - Updated feature.json: passes=true, status=completed, added notes resolution - smoke:qc not verified (bun not available in WSL agent environment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
recovers dirty valid-ID checkouts after owner, name, and casing renamestest runs three full clone-and-reclone scenarios in one body, where its neighbours in the file run one each. On the windows-latest runner that total sits right on Bun's 5000ms default: the 2.2.1 pull request passed on all three platforms, and the identical commit then timed out at 5061ms on the push to main.The budget is now stated at 20s, matching the explicit timeout already carried by
test/cross-platform-release-validation.test.ts, so the scenario count rather than the runner's spawn latency decides the outcome. Test-only; the published 2.2.1 artifact is unaffected.