Skip to content

[AUTOMATED] Preserve same-named functions when reloading artifacts - #119

Open
sjkim1127 wants to merge 1 commit into
Noelo-Lab:mainfrom
sjkim1127:codex/materialized-function-identity
Open

sjkim1127 wants to merge 1 commit into
Noelo-Lab:mainfrom
sjkim1127:codex/materialized-function-identity

Conversation

@sjkim1127

@sjkim1127 sjkim1127 commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

[AUTOMATED]

Reloading a saved artifact kept only the last function when two entries shared a name. Use name@0xADDRESS keys for collisions and keep each record's original name, address, and body. Unique names keep their existing keys. This is the artifact-reload slice of #91.

The regression writes two same-named functions with the existing writer. It fails on main and passes on 41b5317. The focused suite passed 55 tests. With caching disabled, the full local suite had one additional pass and the same 29 failures and 24 errors as main.

[AUTOMATED]

Qualify materialized result keys by address when a name refers to multiple
entries. Verify both entries survive the existing C artifact round trip.
@sjkim1127
sjkim1127 marked this pull request as ready for review November 14, 2026 00:54
Copilot AI balanced review requested due to automatic review settings November 14, 2026 00:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants