Repository navigation
refactor(cluster): bring the calvin dispatch/scheduler and error files back under the 500-line limit #353
Description
Summary
Three files this branch touches exceed, or grow past, the house 500-line
non-test limit, so the local preflight (check C5) fails and was bypassed for the
fix push:
| File | base | head |
|---|---|---|
nodedb/src/control/cluster/calvin/scheduler/driver/core/dispatch.rs |
504 | 542 |
nodedb/src/control/cluster/calvin/scheduler/driver/core/scheduler.rs |
436 | 506 |
nodedb/src/error/types.rs |
589 | 601 |
Work
- extract the busy helpers (
busy_backoff,note_dispatch_busy,
note_dispatch_busy_shared) fromscheduler.rsinto a smallcore/busy.rs; - extract a self-contained piece of
dispatch.rs(for example the active
dispatch path) into its own module and thin the two dispatch sites; - move any
impl Errorhelper block out oferror/types.rsinto a sibling
module (theErrorenum itself cannot be split); - target: every changed file at or under 500 non-test lines, preflight C5 green.
Metadata
Metadata
Assignees
Labels
No labels
Activity
EnRaiha commentedon Sep 20, 2026
Resolved on
fix/calvin-backpressure(PR #355), pushed preflight-clean without a bypass:core/dispatch.rscore/scheduler.rsnodedb/src/error/types.rsbusy_backoff,note_dispatch_busy,note_dispatch_busy_shared) moved tocore/busy.rs; the active dispatch path moved tocore/active_dispatch.rs; the static dispatch site now callsnote_dispatch_busyinstead of duplicating the backoff block.error/types.rshas noimpl Errorblock to move — the file is the enum plus theResultalias — and the enum cannot be split without changing the public API, so it cannot reach 500 non-test lines. It is back below its base count, which is the C5 rule for a pre-existing over-limit file: no growth.cargo check -p nodedband clippy clean · 217 calvin lib tests +busy_backoff_is_bounded_and_jitteredpass.